Re: [PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

[PATCH 00/30] fbdev: Make userspace interfaces optional · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
[PATCH 04/30] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 04/30] fbdev/atyfb: Reorder backlight and framebuffer init/cleanup · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Ruhl, Michael J <hidden> · 2023-06-05
Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Sam Ravnborg <hidden> · 2023-06-05
RE: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Ruhl, Michael J <hidden> · 2023-06-05
Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-06
Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Dan Carpenter <hidden> · 2023-06-06
Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-06
[PATCH 09/30] fbdev/ep93xx-fb: Alloc DMA memory from hardware device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 09/30] fbdev/ep93xx-fb: Alloc DMA memory from hardware device · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 07/30] fbdev/aty128fb: Use hardware device as backlight parent · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 07/30] fbdev/aty128fb: Use hardware device as backlight parent · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 03/30] backlight/lv5207lp: Compare against struct fb_info.device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 03/30] backlight/lv5207lp: Compare against struct fb_info.device · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 21/30] fbdev/sm501fb: Output message with fb_err() · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 21/30] fbdev/sm501fb: Output message with fb_err() · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 14/30] fbdev/nvidiafb: Reorder backlight and framebuffer init/cleanup · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 14/30] fbdev/nvidiafb: Reorder backlight and framebuffer init/cleanup · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 12/30] fbdev/mb862xxfb: Output messages with fb_dbg() and fb_err() · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 12/30] fbdev/mb862xxfb: Output messages with fb_dbg() and fb_err() · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent · Dan Carpenter <hidden> · 2023-06-06
Re: [PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-06
Re: [PATCH 18/30] fbdev/radeonfb: Use hardware device as backlight parent · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 16/30] fbdev/pxa168fb: Do not assign to struct fb_info.dev · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 16/30] fbdev/pxa168fb: Do not assign to struct fb_info.dev · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 06/30] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 06/30] fbdev/aty128fb: Reorder backlight and framebuffer init/cleanup · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 17/30] fbdev/radeonfb: Reorder backlight and framebuffer cleanup · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 17/30] fbdev/radeonfb: Reorder backlight and framebuffer cleanup · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 10/30] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err() · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 10/30] fbdev/ep93xx-fb: Output messages with fb_info() and fb_err() · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 15/30] fbdev/nvidiafb: Use hardware device as backlight parent · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 15/30] fbdev/nvidiafb: Use hardware device as backlight parent · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 05/30] fbdev/atyfb: Use hardware device as backlight parent · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 05/30] fbdev/atyfb: Use hardware device as backlight parent · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 13/30] fbdev/metronomefb: Use hardware device for dev_err() · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 13/30] fbdev/metronomefb: Use hardware device for dev_err() · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 29/30] fbdev/core: Rework fb init code · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 29/30] fbdev/core: Rework fb init code · Sam Ravnborg <hidden> · 2023-06-07
[PATCH 08/30] fbdev/broadsheetfb: Call device_remove_file() with hardware device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 08/30] fbdev/broadsheetfb: Call device_remove_file() with hardware device · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Greg KH <hidden> · 2023-06-05
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · kernel test robot <hidden> · 2023-06-05
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-07
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-07
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-07
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-09
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Sam Ravnborg <hidden> · 2023-06-11
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-12
Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-12
[PATCH 01/30] backlight/bd6107: Compare against struct fb_info.device · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 01/30] backlight/bd6107: Compare against struct fb_info.device · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
Re: [PATCH 01/30] backlight/bd6107: Compare against struct fb_info.device · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 19/30] fbdev/rivafb: Reorder backlight and framebuffer init/cleanup · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 19/30] fbdev/rivafb: Reorder backlight and framebuffer init/cleanup · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 26/30] fbdev/core: Add fb_device_{create,destroy}() · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 26/30] fbdev/core: Add fb_device_{create,destroy}() · Sam Ravnborg <hidden> · 2023-06-07
[PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-12
Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-12
[PATCH 25/30] fbdev/core: Move framebuffer and backlight helpers into separate files · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 25/30] fbdev/core: Move framebuffer and backlight helpers into separate files · Sam Ravnborg <hidden> · 2023-06-07
Re: [PATCH 25/30] fbdev/core: Move framebuffer and backlight helpers into separate files · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-09
[PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev · Dan Carpenter <hidden> · 2023-06-06
Re: [PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 20/30] fbdev/rivafb: Use hardware device as backlight parent · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 20/30] fbdev/rivafb: Use hardware device as backlight parent · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 28/30] fbdev/core: Move file-I/O code into separate file · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file · kernel test robot <hidden> · 2023-06-05
Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file · Sam Ravnborg <hidden> · 2023-06-07
Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-12
Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file · Javier Martinez Canillas <javierm@redhat.com> · 2023-06-07
[PATCH 24/30] fbdev/core: Pass Linux device to pm_vt_switch_*() functions · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 24/30] fbdev/core: Pass Linux device to pm_vt_switch_*() functions · Sam Ravnborg <hidden> · 2023-06-07
[PATCH 27/30] fbdev/core: Move procfs code to separate file · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-05
Re: [PATCH 27/30] fbdev/core: Move procfs code to separate file · Sam Ravnborg <hidden> · 2023-06-07
Re: [PATCH 00/30] fbdev: Make userspace interfaces optional · Geert Uytterhoeven <geert@linux-m68k.org> · 2023-06-07
Re: [PATCH 00/30] fbdev: Make userspace interfaces optional · Thomas Zimmermann <tzimmermann@suse.de> · 2023-06-12

From: Dan Carpenter <hidden>
Date: 2023-06-06 05:26:33
Also in: dri-devel, linux-omap, linux-sh, linux-staging

On Mon, Jun 05, 2023 at 04:47:53PM +0200, Thomas Zimmermann wrote:

Do not assing the Linux device to struct fb_info.dev. The call to
register_framebuffer() initializes the field to the fbdev device.
Drivers should not override its value.

Fixes a bug where the driver incorrectly decreases the hardware
device's reference counter and leaks the fbdev device.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Fixes: 88017bda96a5 ("ep93xx video driver")

regards,
dan carpenter

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help