Thread (96 messages) 96 messages, 8 authors, 2023-06-12

Re: [PATCH 02/30] backlight/gpio_backlight: Compare against struct fb_info.device

From: Sam Ravnborg <hidden>
Date: 2023-06-05 20:23:16
Also in: dri-devel, linux-omap, linux-sh, linux-staging

Hi Michael.
quoted
Fixes a bug in the backlight driver and prepares fbdev for making
struct fb_info.dev optional.
I only see a rename from fbdev  to dev...

Is there missing code?

Would  a fixes: be useful?

M
quoted
@@ -35,7 +35,7 @@ static int gpio_backlight_check_fb(struct
backlight_device *bl,
{
	struct gpio_backlight *gbl = bl_get_data(bl);

-	return gbl->fbdev == NULL || gbl->fbdev == info->dev;
+	return !gbl->dev || gbl->dev == info->device;
}
The real change is here where info->dev is replaced by info->device.

	Sam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help