Re: [PATCH 11/30] fbdev/ep93xx-fb: Do not assign to struct fb_info.dev

From
Javier Martinez Canillas <javierm@redhat.com>
Date
2023-06-07 09:00:26
Also in
dri-devel, linux-omap, linux-sh, linux-staging
Reply to
Thomas Zimmermann, 2023-06-05
Thomas Zimmermann [off-list ref] writes:
Do not assing the Linux device to struct fb_info.dev. The call to
register_framebuffer() initializes the field to the fbdev device.
Drivers should not override its value.

Fixes a bug where the driver incorrectly decreases the hardware
device's reference counter and leaks the fbdev device.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat
Thread (96 messages) 96 messages, 8 authors, last reply 2023-06-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help