Re: patch fixing background next to penguin logo in monochrome

On Thu, 16 Sep 2004, Antonino A. Daplas wrote:

On Sunday 15 August 2004 20:25, Geert Uytterhoeven wrote:

quoted

quoted

This one is a little difficult since there is currently no method to
convert monochrome attributes to color and vice versa.  The best one can
do is to clear all attributes when switching from mono<->color.

When switching, one will get plain text only.  This is  probably better
than having text with incorrect attributes.

Attached patch is completely untested, but it's the same one in 2.6.

Doesn't help, still the same behavior :-(

I looked at the code, and the flow seems to be like this:

fbcon_switch->fb_set_var->changevar->fbcon_setup->update_screen/redraw_screen

However, fbcon_setup() updates conp->vc_can_do_color, so by the time
the redraw_screen function in console.c checks for the vc_can_do_color field,
it always returns equal.

So instead of clearing the buffer attributes in redraw_screen(), we do it
instead in fbcon_setup().

Try the patch below.  You might have to apply them manually as I'm using
Suse-9.0 linux kernel, which has the bootsplash code.  Also, all the previous
patches need to be reversed.

Applied fine, but still the same result.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285