Re: patch fixing background next to penguin logo in monochrome

On Thu, 12 Aug 2004, Petr Stehlik wrote:

V Ne, 12. 09. 2004 v 00:16, Antonino A. Daplas pí¨e:

quoted

On Thursday 12 August 2004 03:56, Petr Stehlik wrote:

quoted

I have developed a simple workaround for a problem existing in
framebuffer when it interprets VGA attribute bits in monochrome mode.
Instead of empty chars we get underlines

quoted

Anyway, the simplest solution is to use a vc->vc_video_erase_char with the
underline attribute removed.  Check drivers/video/fbcon.c and look at the
function fbcon_setup. Note, the logo space is erased using the scr_memsetw
function with conp->vc_video_erase_char. Just replace them with
(conp->vc_video_erase_char & ~0x400) if conp->can_do_color is false. (0x400
is the underline attribute).

Good idea. Tested, works. Included below.

Thanks a lot! Works fine on Amiga as well!

BTW, I checked in a slightly modified version in Linux/m68k CVS
(http://linux-m68k-cvs.ubb.ca/~geert/linux-m68k-2.4.x-merging/162-logo.diff).

Gr{oetje,eeting}s,

						Geert

P.S. There are still problems when switching from color to monochrome
     (underlines appear everywhere) or vice versa (text becomes blue), but I
     cannot expect you to fix all old bugs in one week ;-)
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285