Re: patch fixing background next to penguin logo in monochrome

On Friday 13 August 2004 16:05, Geert Uytterhoeven wrote:

quoted

diff -uprN linux-2.4-orig/drivers/video/fbcon.c
linux-2.4/drivers/video/fbcon.c ---
linux-2.4-orig/drivers/video/fbcon.c	2004-09-13 07:40:18.194333488 +0800

+++ linux-2.4/drivers/video/fbcon.c	2004-09-13 07:41:52.302026944 +0800

@@ -1930,6 +1930,7 @@ static int fbcon_switch(struct vc_data *
 	(*info->switch_con)(unit, info);
     if (p->dispsw->clear_margins && vt_cons[unit]->vc_mode == KD_TEXT)
 	p->dispsw->clear_margins(conp, p, 0);
+    conp->vc_can_do_color = p->var.bits_per_pixel != 1;
     if (logo_shown == -2) {
 	/* G.S.: Display a line above the Boot Logo to state what
 	* version of the kernel we are booting.

I don't think it's needed: I saw no artifacts when switching between a
monochrome and a color VC or vice versa.

When looking at the source, conp->vc_can_do_color is initialized in
fbcon_setup(), which is called from fbcon_changevar(), which is called by
the fbdev if the resolution or color depth was changed.

Okay.  I wasn't too sure of that since I'm not very familiar with the 2.4
code.

Tony




-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285