Re: patch fixing background next to penguin logo in monochrome

On Monday 13 September 2004 06:25, Antonino A. Daplas wrote:

quoted

On Friday 13 August 2004 04:01, Geert Uytterhoeven wrote:

quoted

P.S. There are still problems when switching from color to monochrome
     (underlines appear everywhere) or vice versa (text becomes blue),
but I cannot expect you to fix all old bugs in one week ;-)

This one is a little difficult since there is currently no method to
convert monochrome attributes to color and vice versa.  The best one can do
is to clear all attributes when switching from mono<->color.

When switching, one will get plain text only.  This is  probably better
than having text with incorrect attributes.

Attached patch is completely untested, but it's the same one in 2.6.

I think the conp->vc_can_do_color field also needs to be updated during fbcon_switch.

Tony
---

diff -uprN linux-2.4-orig/drivers/video/fbcon.c linux-2.4/drivers/video/fbcon.c

--- linux-2.4-orig/drivers/video/fbcon.c	2004-09-13 07:40:18.194333488 +0800
+++ linux-2.4/drivers/video/fbcon.c	2004-09-13 07:41:52.302026944 +0800

@@ -1930,6 +1930,7 @@ static int fbcon_switch(struct vc_data *
 	(*info->switch_con)(unit, info);
     if (p->dispsw->clear_margins && vt_cons[unit]->vc_mode == KD_TEXT)
 	p->dispsw->clear_margins(conp, p, 0);
+    conp->vc_can_do_color = p->var.bits_per_pixel != 1;
     if (logo_shown == -2) {
 	/* G.S.: Display a line above the Boot Logo to state what
 	* version of the kernel we are booting.