Thread (18 messages) 18 messages, 4 authors, 2021-06-25

Re: [External] Re: [PATCH v23 6/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page

From: Oscar Salvador <osalvador@suse.de>
Date: 2021-05-11 08:07:21
Also in: linux-fsdevel, linux-mm, lkml

On Mon, May 10, 2021 at 08:19:47PM +0800, Muchun Song wrote:
Not exactly right. free_huge_page() does not clear HPageTemporary
if the page is temporarily allocated when freeing. You are right that
dissolve_free_huge_page() does not clear HPageFreed.
Right, I missed that.
Because I think it is the reverse operation of remove_hugetlb_page,
I named it add_hugetlb_page. Do you have any suggestions for
renaming?
Ok, if it is the counter part, the name makes sense.
I would have appreciated a comment explaining e.g: under which
circumtances is being called, etc. but not a blocker, can be done on
top.

Reviewed-by: Oscar Salvador <osalvador@suse.de>


-- 
Oscar Salvador
SUSE L3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help