Thread (18 messages) flat view 18 messages, 4 authors, 2021-06-25

Re: [External] Re: [PATCH v23 8/9] mm: memory_hotplug: disable memmap_on_memory when hugetlb_free_vmemmap enabled

From: Muchun Song <hidden>
Date: 2021-05-10 10:45:43
Also in: linux-fsdevel, linux-mm, lkml

On Mon, May 10, 2021 at 6:08 PM Oscar Salvador [off-list ref] wrote:
On Mon, May 10, 2021 at 11:00:26AM +0800, Muchun Song wrote:
quoted
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 8cc195c4c861..0d7f595ee441 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -15,6 +15,7 @@
 #include <linux/acpi.h>
 #include <linux/memory.h>
 #include <linux/memory_hotplug.h>
+#include <linux/hugetlb.h>

 #include "internal.h"
Uhm, I am confused.
Why do we need this here? AFAICS, we do not.

The function is in memory_hotplug.c, and that alrady has that include.
What am I missing?
You are right. That include is redundant. I will remove it
from acpi_memhotplug.c. Thanks Oscar.

--
Oscar Salvador
SUSE L3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help