Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the... | linux-doc

[PATCH v18 0/9] Free some vmemmap pages of HugeTLB page · Muchun Song <hidden> · 2021-03-08
[PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [External] Re: [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [External] Re: [PATCH v18 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem_info.c · Muchun Song <hidden> · 2021-03-11
[PATCH v18 3/9] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 3/9] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [External] Re: [PATCH v18 3/9] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page · Muchun Song <hidden> · 2021-03-11
[PATCH v18 2/9] mm: hugetlb: introduce a new config HUGETLB_PAGE_FREE_VMEMMAP · Muchun Song <hidden> · 2021-03-08
[PATCH v18 5/9] mm: hugetlb: set the PageHWPoison to the raw error page · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 5/9] mm: hugetlb: set the PageHWPoison to the raw error page · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [External] Re: [PATCH v18 5/9] mm: hugetlb: set the PageHWPoison to the raw error page · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 5/9] mm: hugetlb: set the PageHWPoison to the raw error page · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [External] Re: [PATCH v18 5/9] mm: hugetlb: set the PageHWPoison to the raw error page · Muchun Song <hidden> · 2021-03-11
[PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Oscar Salvador <osalvador@suse.de> · 2021-03-10
Re: [External] Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Muchun Song <hidden> · 2021-03-11
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Mike Kravetz <hidden> · 2021-03-10
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · "Paul E. McKenney" <paulmck@kernel.org> · 2021-03-10
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Mike Kravetz <hidden> · 2021-03-10
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · "Paul E. McKenney" <paulmck@kernel.org> · 2021-03-10
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Mike Kravetz <hidden> · 2021-03-11
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Mike Kravetz <hidden> · 2021-03-11
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-12
Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Mike Kravetz <hidden> · 2021-03-12
Re: [External] Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [External] Re: [PATCH v18 4/9] mm: hugetlb: alloc the vmemmap pages associated with each HugeTLB page · Muchun Song <hidden> · 2021-03-11
[PATCH v18 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [PATCH v18 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap · Randy Dunlap <hidden> · 2021-03-10
Re: [External] Re: [PATCH v18 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 6/9] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap · Muchun Song <hidden> · 2021-03-11
[PATCH v18 7/9] mm: hugetlb: introduce nr_free_vmemmap_pages in the struct hstate · Muchun Song <hidden> · 2021-03-08
[PATCH v18 8/9] mm: hugetlb: gather discrete indexes of tail page · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 8/9] mm: hugetlb: gather discrete indexes of tail page · Michal Hocko <mhocko@suse.com> · 2021-03-10
[PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Muchun Song <hidden> · 2021-03-08
Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Michal Hocko <mhocko@suse.com> · 2021-03-10
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Michal Hocko <mhocko@suse.com> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Muchun Song <hidden> · 2021-03-11
Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler · Oscar Salvador <osalvador@suse.de> · 2021-03-11

Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler

From: Muchun Song <hidden>
Date: 2021-03-11 13:01:31
Also in: linux-fsdevel, linux-mm, lkml

On Thu, Mar 11, 2021 at 8:16 PM Michal Hocko [off-list ref] wrote:

On Thu 11-03-21 18:00:09, Muchun Song wrote:
[...]

quoted

Sorry. I am confused why you disagree with this change.
It does not bring any disadvantages.

Because it is adding a code which is not really necessary and which will
have to be maintained. Think of future changes which would need to grow
more of these. Hugetlb code paths shouldn't really think about size of
the struct page.

Got it. I will drop this patch.

--
Michal Hocko
SUSE Labs

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help