Re: [External] Re: [PATCH v18 9/9] mm: hugetlb: optimize the code with the help of the compiler

On Thu, Mar 11, 2021 at 8:16 PM Michal Hocko [off-list ref] wrote:

On Thu 11-03-21 18:00:09, Muchun Song wrote:
[...]

quoted

Sorry. I am confused why you disagree with this change.
It does not bring any disadvantages.

Because it is adding a code which is not really necessary and which will
have to be maintained. Think of future changes which would need to grow
more of these. Hugetlb code paths shouldn't really think about size of
the struct page.

Got it. I will drop this patch.

--
Michal Hocko
SUSE Labs