Thread (36 messages) 36 messages, 6 authors, 2023-02-26

Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node

From: yanhong wang <hidden>
Date: 2023-02-03 09:02:08
Also in: linux-riscv, lkml, netdev


On 2023/2/3 15:56, Krzysztof Kozlowski wrote:
On 03/02/2023 08:40, yanhong wang wrote:
quoted
quoted
Sorry, I didn't check all the bindings, only the modified ones, the command 
used is as follows: 
"make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml"
"make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml"
That's good actually, except that you change binding used by others, so
you affect other files.

However in this DTS you will have now warnings (dtbs_check with
simple-bus or dtbs W=1) because of using non-MMIO node in your soc-bus.
The stmmac-axi-config probably should be moved outside of soc node. Or
you keep two of them - one in each ethernet node.
Thanks. The stmmac-axi-config probably will be moved outside of soc node in the next version.
Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help