Re: [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node
From: Krzysztof Kozlowski <hidden>
Date: 2023-02-03 07:56:26
Also in:
linux-riscv, lkml, netdev
On 03/02/2023 08:40, yanhong wang wrote:
quoted
Sorry, I didn't check all the bindings, only the modified ones, the command used is as follows: "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/snps,dwmac.yaml" "make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml"
That's good actually, except that you change binding used by others, so you affect other files. However in this DTS you will have now warnings (dtbs_check with simple-bus or dtbs W=1) because of using non-MMIO node in your soc-bus. The stmmac-axi-config probably should be moved outside of soc node. Or you keep two of them - one in each ethernet node. Best regards, Krzysztof