Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example

On 17:01-20210920, Bjorn Andersson wrote:

On Mon 20 Sep 16:14 CDT 2021, Suman Anna wrote:

quoted

On 9/17/21 9:44 AM, Nishanth Menon wrote:

quoted

On 15:17-20210917, Sinthu Raja wrote:

quoted

From: Sinthu Raja <redacted>

The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.

Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---

This patch was triggered by discussions in [1].

When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context

Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).

Hmm, I don't think an immutable tag is needed for this patch. This is just
cleanup, what is your exact dependency here?

The relevant HwSpinlock dts nodes are all upstream on all applicable platforms
already.

I agree and in general I think it's better to do DT validation against
linux-next, as you would otherwise miss out on any newly introduced
issues from inherited bindings etc.

I agree that an immutable commit is not needed on this specific patch.
The updated revision[1] posted had already dropped that request.

On the other hand, series[2] makes Rob's checks fail (as it runs on
rc1) - and helps keep everyone sane by getting an immutable commit
merged in allowing for follow on patches to stay clean.

NOTE: I do test patches for both checks and functionality to the best I
can on both rc1 (my tree)[3] and on linux-next on the day I pick the
patches up.

[1] https://lore.kernel.org/all/20210920123152.32751-1-sinthu.raja@ti.com/ (local)
[2] https://lore.kernel.org/all/20210917095426.19277-1-sinthu.raja@ti.com/ (local)
[3] https://git.kernel.org/pub/scm/linux/kernel/git/nmenon/linux.git/tree/
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D