Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example

On Mon 20 Sep 16:14 CDT 2021, Suman Anna wrote:

On 9/17/21 9:44 AM, Nishanth Menon wrote:

quoted

On 15:17-20210917, Sinthu Raja wrote:

quoted

From: Sinthu Raja <redacted>

The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.

Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---

This patch was triggered by discussions in [1].

When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context

Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).

Hmm, I don't think an immutable tag is needed for this patch. This is just
cleanup, what is your exact dependency here?

The relevant HwSpinlock dts nodes are all upstream on all applicable platforms
already.

I agree and in general I think it's better to do DT validation against
linux-next, as you would otherwise miss out on any newly introduced
issues from inherited bindings etc.

Regards,
Bjorn

regards
Suman

quoted

Reviewed-by: Nishanth Menon <nm@ti.com>

quoted

[1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/ (local)
[2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/ (local)

 .../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml        | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
index ae1b37dbee75..d56dc1bebdc6 100644
--- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml

@@ -47,10 +47,8 @@ examples:
     };
 
   - |
-    / {
+    soc {
         /* K3 AM65x SoCs */
-        model = "Texas Instruments K3 AM654 SoC";
-        compatible = "ti,am654-evm", "ti,am654";
         #address-cells = <2>;
         #size-cells = <2>;
 

-- 
2.32.0