From: Sinthu Raja <hidden> Date: 2021-09-17 09:48:34
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context
[1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/
[2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/
.../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context
Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).
Reviewed-by: Nishanth Menon <nm@ti.com>
From: Suman Anna <hidden> Date: 2021-09-20 21:16:40
On 9/17/21 9:44 AM, Nishanth Menon wrote:
On 15:17-20210917, Sinthu Raja wrote:
quoted
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context
Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).
Hmm, I don't think an immutable tag is needed for this patch. This is just
cleanup, what is your exact dependency here?
The relevant HwSpinlock dts nodes are all upstream on all applicable platforms
already.
regards
Suman
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context
Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).
Hmm, I don't think an immutable tag is needed for this patch. This is just
cleanup, what is your exact dependency here?
The relevant HwSpinlock dts nodes are all upstream on all applicable platforms
already.
I agree and in general I think it's better to do DT validation against
linux-next, as you would otherwise miss out on any newly introduced
issues from inherited bindings etc.
Regards,
Bjorn
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context
Aah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is
bindings).
Hmm, I don't think an immutable tag is needed for this patch. This is just
cleanup, what is your exact dependency here?
The relevant HwSpinlock dts nodes are all upstream on all applicable platforms
already.
I agree and in general I think it's better to do DT validation against
linux-next, as you would otherwise miss out on any newly introduced
issues from inherited bindings etc.
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
I do think your fix is correct in that it results in a proper tree, but
the examples are not supposed to describe the node in a fully described
DT tree, but rather just show an example of the particular binding.
I therefor think that it would be appropriate to reduce that second
example to just:
spinlock@30e00000 {
compatible = "ti,am654-hwspinlock";
reg = <0x30e00000 0x1000>;
#hwlock-cells = <1>;
};
Because the rest has nothing to do with this binding.
That said, this example is now the same example as the first one, just
with different compatible, so I think we should drop the entire second
example instead.
PS. While we're doing that, we should also remove the "hwspinlock: "
label from the first example.
Regards,
Bjorn
quoted hunk
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the context
[1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/
[2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/
.../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)