Re: [PATCH] dt-bindings: hwlock: omap: Remove board-specific compatible from DT example
From: Nishanth Menon <nm@ti.com>
Date: 2021-09-17 14:46:00
Also in:
linux-arm-kernel, linux-remoteproc, lkml
On 15:17-20210917, Sinthu Raja wrote:
From: Sinthu Raja <redacted>
The example includes a board-specific compatible property, this is
wrong as the example should be board agnostic. Replace the same with a
generic soc node.
Fixes: d8db9dc34871 ("dt-bindings: hwlock: omap: Convert binding to YAML")
Signed-off-by: Sinthu Raja <redacted>
---
This patch was triggered by discussions in [1].
When applying the patch, if you could provide an immutable tag for the
bindings, it would help line things up for new platforms to be added for
us. See [2] for the contextAah yes, thanks.. Bjorn.. once Rob acks ofcourse (since this is bindings). Reviewed-by: Nishanth Menon <nm@ti.com>
quoted hunk ↗ jump to hunk
[1] https://lore.kernel.org/all/20210818074030.1877-1-sinthu.raja@ti.com/ (local) [2] https://lore.kernel.org/linux-arm-kernel/20210125141642.4yybjnklk3qsqjdy@steersman/ (local) .../devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml index ae1b37dbee75..d56dc1bebdc6 100644 --- a/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml +++ b/Documentation/devicetree/bindings/hwlock/ti,omap-hwspinlock.yaml@@ -47,10 +47,8 @@ examples: }; - | - / { + soc { /* K3 AM65x SoCs */ - model = "Texas Instruments K3 AM654 SoC"; - compatible = "ti,am654-evm", "ti,am654"; #address-cells = <2>; #size-cells = <2>;-- 2.32.0
-- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D