Hi Tim:
Just as Ahmad mentioned, Lucas had issue one patch-set to support i.MX8MM PCIe.
Some comments in the review cycle.
- One separate PHY driver should be used for i.MX8MM PCIe driver.
- Schema file should be used I think, otherwise the .txt file in the dt-binding.

I'm preparing one patch-set, but it's relied on the yaml file exchanges and power-domain changes(block control and so on).
Up to now, I only walking on the first step, trying to exchange the dt-binding files to schema yaml file.

Best Regards
Richard Zhu

-----Original Message-----
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Sent: Thursday, July 29, 2021 10:40 PM
To: tharvey@gateworks.com; Richard Zhu <hongxing.zhu@nxp.com>; Lucas
Stach [off-list ref]; Bjorn Helgaas [off-list ref];
Rob Herring [off-list ref]; Shawn Guo [off-list ref];
Sascha Hauer [off-list ref]; Pengutronix Kernel Team
[off-list ref]; Fabio Estevam [off-list ref];
dl-linux-imx [off-list ref]; linux-pci@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org;
linux-kernel@vger.kernel.org; Krzysztof Wilczyński [off-list ref]; Lorenzo
Pieralisi [off-list ref]
Subject: Re: [PATCH 0/6] Add IMX8M Mini PCI support

Hello Tim,

On 23.07.21 22:49, Tim Harvey wrote:

quoted

The IMX8M Mini PCI controller shares much in common with the existing
SoC's supported by the pci-imx6 driver.

This series adds support for it. Driver changes came from the NXP
downstream vendor kernel [1]

This series depends on Lucas Stach's i.MX8MM GPC improvements and
BLK_CTRL driver and is based on top of his v2 submission [2]

Are you aware of Lucas' patch series and Rob's remarks there?
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ke
rnel.org%2Flinux-pci%2F20210510141509.929120-7-l.stach%40pengutronix.
de%2F&data=04%7C01%7Chongxing.zhu%40nxp.com%7C21a3e2ba936
c443581ea08d9529ebf65%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7
C0%7C637631664036013517%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a
mp;sdata=blnp2JkmGAZ2w5JHZHJQoZJSuY1646KAT8cccaI5n%2Fw%3D&
reserved=0

Cheers,
Ahmad

quoted

The final patch adds PCIe support to the Tim [1]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour

ce.codeaurora.org%2Fexternal%2Fimx%2Flinux-imx%2F&data=04%7C0
1%7Ch

quoted

ongxing.zhu%40nxp.com%7C21a3e2ba936c443581ea08d9529ebf65%7C686e
a1d3bc2

quoted

b4c6fa92cd99c5c301635%7C0%7C0%7C637631664036013517%7CUnknown
%7CTWFpbGZ

quoted

sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
n0%3

quoted

D%7C1000&sdata=5IiG4fnzWkcsV2JPnQJ8gAgMhZSuZypTOixD4lV%2BTf
g%3D&am

quoted

p;reserved=0
[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc

hwork.kernel.org%2Fproject%2Flinux-arm-kernel%2Flist%2F%3Fseries%3D51
9

quoted

251&data=04%7C01%7Chongxing.zhu%40nxp.com%7C21a3e2ba936c44
3581ea08

quoted

d9529ebf65%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63763
166403601

quoted

3517%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
MzIiLCJBT

quoted

iI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=M6%2FzPsxRPv%2Fv7a
ad7uqjDQY

quoted

8LhHOX%2B%2FLzxnuW1UrVgE%3D&reserved=0

Tim Harvey (6):
  dt-bindings: imx6q-pcie: add compatible for IMX8MM support
  dt-bindings: reset: imx8mq: add pcie reset
  PCI: imx6: add IMX8MM support
  reset: imx7: add resets for PCIe
  arm64: dts: imx8mm: add PCIe support
  arm64: dts: imx8mm: add gpc iomux compatible

 .../bindings/pci/fsl,imx6q-pcie.txt           |   4 +-
 arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  38 ++++++-
 drivers/pci/controller/dwc/pci-imx6.c         | 103

+++++++++++++++++-

quoted

 drivers/reset/reset-imx7.c                    |   3 +
 include/dt-bindings/reset/imx8mq-reset.h      |   3 +-
 5 files changed, 147 insertions(+), 4 deletions(-)

--
Pengutronix e.K.                           |
|
Steuerwalder Str. 21                       |
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
engutronix.de%2F&data=04%7C01%7Chongxing.zhu%40nxp.com%7C21
a3e2ba936c443581ea08d9529ebf65%7C686ea1d3bc2b4c6fa92cd99c5c3016
35%7C0%7C0%7C637631664036013517%7CUnknown%7CTWFpbGZsb3d8ey
JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
%7C1000&sdata=jynjjRJZyvooJFXwvz45OU9YB0xr5wA2y%2FkoweEtUq
U%3D&reserved=0  |
31137 Hildesheim, Germany                  | Phone:
+49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:
+49-5121-206917-5555 |