Re: [PATCH v2 7/7] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY
From: Rob Herring <robh+dt@kernel.org>
Date: 2021-07-28 17:23:29
Also in:
lkml, netdev
On Mon, Jul 26, 2021 at 11:53 PM Oleksij Rempel [off-list ref] wrote:
On Mon, Jul 12, 2021 at 04:06:31PM +0300, alexandru.tachici@analog.com wrote:quoted
From: Alexandru Tachici <redacted> DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY. Signed-off-by: Alexandru Tachici <redacted> --- .../devicetree/bindings/net/adi,adin1100.yaml | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yamldiff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml new file mode 100644 index 000000000000..14943164da7a --- /dev/null +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml@@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADIN1100 PHY + +maintainers: + - Alexandru Tachici <alexandru.tachici@analog.com> + +description: + Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + adi,disable-2400mv-tx-level: + description: + Prevent ADIN1100 from using the 2.4 V pk-pk transmit level. + type: booleanThis property should be generic. It is defined by IEEE 802.3cg 2019 and can be implemented on all T1L PHYs. I assume, it should be something like: ethernet-phy-10base-t1l-2.4vpp-enable ethernet-phy-10base-t1l-2.4vpp-disable
'ethernet-phy-' is a bit redundant and I'd make it a tristate (not present, 0, 1). So just '10base-t1l-2.4vpp'?
To overwrite bootstrapped of fuzed values if supported. The IEEE 802.3cg specification uses following wordings for this functionality: "10BASE-T1L increased transmit level request ..."