Re: [PATCH v2 7/7] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-07-27 05:54:00
Also in:
lkml, netdev
On Mon, Jul 12, 2021 at 04:06:31PM +0300, alexandru.tachici@analog.com wrote:
quoted hunk ↗ jump to hunk
From: Alexandru Tachici <redacted> DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY. Signed-off-by: Alexandru Tachici <redacted> --- .../devicetree/bindings/net/adi,adin1100.yaml | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yamldiff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml new file mode 100644 index 000000000000..14943164da7a --- /dev/null +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml@@ -0,0 +1,45 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADIN1100 PHY + +maintainers: + - Alexandru Tachici <alexandru.tachici@analog.com> + +description: + Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY + +allOf: + - $ref: ethernet-phy.yaml# + +properties: + adi,disable-2400mv-tx-level: + description: + Prevent ADIN1100 from using the 2.4 V pk-pk transmit level. + type: boolean
This property should be generic. It is defined by IEEE 802.3cg 2019 and can be implemented on all T1L PHYs. I assume, it should be something like: ethernet-phy-10base-t1l-2.4vpp-enable ethernet-phy-10base-t1l-2.4vpp-disable To overwrite bootstrapped of fuzed values if supported. The IEEE 802.3cg specification uses following wordings for this functionality: "10BASE-T1L increased transmit level request ..." "146.5.4.1 Transmitter output voltage When tested with the test fixture shown in Figure 146–20 with the transmitter in test mode 1, the transmitter output voltage shall be 2.4 V + 5%/ – 15% peak-to-peak (for the 2.4 Vpp operating mode) and 1.0 V + 5%/ – 15% peak-to-peak (for the 1.0 Vpp operating mode). Transmitter output voltage can be set using the management interface or by hardware default set-up." I would recommend to use similar wording if possible.
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ ethernet@e000c000 {
+ compatible = "cdns,zynq-gem", "cdns,gem";
+ reg = <0xe000c000 0x1000>;
+ status = "okay";
+ phy-mode = "mii";
+ interrupts = <0 45 4>;
+ clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>;
+ clock-names = "pclk", "hclk", "tx_clk";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet-phy@0 {
+ reg = <0>;
+ device_type = "ethernet-phy";
+ adi,disable-2400mv-tx-level;
+ };
+
+ };
--
2.25.1
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |