Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery
From: H. Nikolaus Schaller <hidden>
Date: 2016-01-06 08:11:36
Also in:
linux-omap, lkml
Hi Tony, Am 06.01.2016 um 02:00 schrieb Tony Lindgren [off-list ref]:
* Nishanth Menon [off-list ref] [160105 15:40]:quoted
On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote:quoted
tested on OMP5432 EVM Signed-off-by: H. Nikolaus Schaller <redacted> --- arch/arm/boot/dts/omap5-board-common.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi index 5cf76a1..30c0d3b 100644 --- a/arch/arm/boot/dts/omap5-board-common.dtsi +++ b/arch/arm/boot/dts/omap5-board-common.dtsi@@ -358,6 +358,14 @@#clock-cells = <0>; }; + rtc { + compatible = "ti,palmas-rtc"; + interrupt-parent = <&palmas>; + interrupts = <8 IRQ_TYPE_NONE>;IRQ_TYPE_NONE is not correct here -> it should have some polarity - if it had none, there'd be no interrupt, right?Also I'm not seeing just zeroes coming from RTC after typing hwclock on omap5-uevm. It's working on x15 though. Nikolaus, is hwclock command working for you on omap5-uevm?
Well, yes and no. It appears it *was* working when tested last time (we sometimes have months of delay for submitting patches upstream). I have found an SD image with 4.3-rc6 with this patch in the dtb and there it works. With 4.4-rc8 it does not work. hwclock command hangs for 10 seconds (I guess some timeout). I have checked the dtb and in both cases it is interrupts = <8 0>; xxd /sys/firmware/devicetree/base/ocp/i2c@48070000/palmas@48/rtc/interrupts 0000000: 0000 0008 0000 0000 So I think something has changed in the rtc driver or somewhere else. BR, Nikolaus