Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery

Hi,

Am 06.01.2016 um 00:40 schrieb Nishanth Menon [off-list ref]:

On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote:

quoted

tested on OMP5432 EVM

Signed-off-by: H. Nikolaus Schaller <redacted>
---
arch/arm/boot/dts/omap5-board-common.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index 5cf76a1..30c0d3b 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi

@@ -358,6 +358,14 @@

			#clock-cells = <0>;
		};

+		rtc {
+			compatible = "ti,palmas-rtc";
+			interrupt-parent = <&palmas>;
+			interrupts = <8 IRQ_TYPE_NONE>;

IRQ_TYPE_NONE is not correct here -> it should have some polarity - if
it had none, there'd be no interrupt, right?

Well, it just translates IRQ_TYPE_NONE through

Linux/include/dt-bindings/interrupt-controller/irq.h

to 

interrupts = <8 0>;

which is given as an example in

Documentation//devicetree/bindings/rtc/rtc-palmas.txt

Since I don't know anything about the rtc driver beyond the bindings documentation I assume it is correct...
I have added Laxman Dewangan because he introduced this interrupts = <8 0>;

quoted

+			ti,backup-battery-chargeable;
+			ti,backup-battery-charge-high-current;
+		};
+
		palmas_pmic {
			compatible = "ti,palmas-pmic";
			interrupt-parent = <&palmas>;

-- 
Regards,
Nishanth Menon

BR,
Nikolaus