Re: [PATCH v2 6/7] Watchdog: introduce ARM SBSA watchdog driver
From: Fu Wei <hidden>
Date: 2015-05-25 02:00:29
Also in:
linux-watchdog, lkml
Hi, Guenter, On 25 May 2015 at 01:32, Guenter Roeck [off-list ref] wrote:
On 05/24/2015 10:19 AM, Timur Tabi wrote:quoted
Fu Wei wrote:quoted
I don't know why you want to do this tricky way. you can always register the interrupt handler, if pre-timeout is 0, system will just trigger WS1 right after WS0But that only works if the pre-timeout and timeout can be programmed to separate values. And as Guenter says, the SBSA may not guarantee that.The pseudo-code in the specification suggests that if WCV is configured, WS0 = WCV WS1 = WCV + WOR Assuming that the implementation follows the pseudo-code in the specification, we would have separately programmable values. Since the pretimeout (per ABI) is the difference in seconds to the timeout, and not an absolute value, we would have to program the registers as follows. WCV = timeout - pretimeout; WOR = pretimeout;
yes, this patchset is doing this way.
Does this make sense ? Thanks, Guenter
-- Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021