Thread (108 messages) 108 messages, 7 authors, 2015-05-25

Re: [PATCH v2 3/7] ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts

From: Fu Wei <hidden>
Date: 2015-05-21 08:49:39
Also in: linux-watchdog, lkml

Hi Arnd,

yes, you are right , will delete it :-)

On 21 May 2015 at 16:45, Arnd Bergmann [off-list ref] wrote:
On Thursday 21 May 2015 16:32:32 fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote:
quoted
+       watchdog0: watchdog@2a450000 {
+               compatible = "arm,sbsa-gwdt";
+               reg = <0x0 0x2a450000 0 0x10000>,
+                       <0x0 0x2a440000 0 0x10000>;
+               reg-names = "refresh",
+                       "control";
+               interrupts = <0 27 4>;
+               interrupt-names = "ws0";
+               timeout-sec = <10 5>;
+       };
 };
just one tiny comment: you can drop the 'watchdog0:' label here, there
is normally no reason to assign a label to a watchdog device, especially
if it's in a .dts file rather than a .dtsi.

The same is true for the example in the binding documentation.

        Arnd


-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help