Re: [PATCH/RFC v10 17/19] DT: Add documentation for exynos4-is 'flashes' property
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date: 2015-01-21 16:33:16
Also in:
linux-leds, linux-media, lkml
Hi, On 09/01/15 16:23, Jacek Anaszewski wrote:
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski <redacted> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
quoted hunk ↗ jump to hunk
--- .../devicetree/bindings/media/samsung-fimc.txt | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 922d6f8..22a6b2f 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt@@ -40,6 +40,12 @@ should be inactive. For the "active-a" state the camera port A must be activated and the port B deactivated and for the state "active-b" it should be the other way around. +Optional properties: + +- flashes - Array of phandles to flash LED devices, or their sub-nodes + representing sub-leds. + (see Documentation/devicetree/bindings/leds/common.txt)
How about renaming this to "illuminators" or something else more generic? The "torch" LED (for video recording illumination?) is not really a flash.
quoted hunk ↗ jump to hunk
+ The 'camera' node must include at least one 'fimc' child node.@@ -166,6 +172,7 @@ Example: clock-output-names = "cam_a_clkout", "cam_b_clkout"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + flashes = <&camera_flash>, <&system_torch>; status = "okay"; #address-cells = <1>; #size-cells = <1>;
-- Thanks, Sylwester