Re: [PATCH/RFC v10 03/19] DT: leds: Add led-sources property
From: Rob Herring <hidden>
Date: 2015-01-20 17:29:40
Also in:
linux-leds, linux-media, lkml
On Tue, Jan 20, 2015 at 10:09 AM, Jacek Anaszewski [off-list ref] wrote:
On 01/16/2015 04:52 PM, Jacek Anaszewski wrote:quoted
On 01/16/2015 02:48 PM, Rob Herring wrote:
[...]
quoted
quoted
You may want to add something like led-output-cnt or led-driver-cnt in the parent so you know the max list size.Why should we need this? The number of current outputs exposed by the device is fixed and can be specified in a LED device bindings documentation.OK. The led-output-cnt property should be put in each sub-node, as the number of the current outputs each LED can be connected to is variable.
Sorry, I meant this for the parent node meaning how many outputs the driver IC has. I did say maybe because you may always know this. It can make it easier to allocate memory for led-sources knowing the max size up front. Rob
quoted hunk ↗ jump to hunk
New version: Optional properties for child nodes: +led-sources-cnt : Number of device current outputs the LED is connected to. +- led-sources : List of device current outputs the LED is connected to. The + outputs are identified by the numbers that must be defined + in the LED device binding documentation. - label : The label for this LED. If omitted, the label is taken from the node name (excluding the unit address).@@ -33,7 +47,9 @@ system-status { camera-flash { label = "Flash"; + led-sources-cnt = <2>; + led-sources = <0>, <1>; max-microamp = <50000>; flash-max-microamp = <320000>; flash-timeout-us = <500000>; -} +}; --Best Regards, Jacek Anaszewski