Re: [PATCH] mfd: qcom-spmi-pmic: Add support for more chips versions
From: Ivan T. Ivanov <hidden>
Date: 2014-11-10 07:46:15
Also in:
linux-arm-msm, lkml
Hi Gilad, On Fri, 2014-11-07 at 17:08 -0700, Gilad Avidov wrote:
On 11/6/2014 12:54 AM, Ivan T. Ivanov wrote:quoted
On Wed, 2014-11-05 at 17:36 -0800, Bjorn Andersson wrote:quoted
On Wed, Nov 5, 2014 at 10:31 AM, Ivan T. Ivanov [off-list ref] wrote:quoted
On Wed, 2014-11-05 at 10:11 -0800, Bjorn Andersson wrote:quoted
On Tue, Nov 4, 2014 at 5:33 AM, Ivan T. Ivanov [off-list ref] wrote: [..]quoted
@@ -28,11 +144,27 @@ static int pmic_spmi_probe(struct spmi_device*sdev) { struct device_node *root = sdev->dev.of_node; struct regmap *regmap; + struct property *prop; + int major, minor, ret; + char *name, compatible[32]; regmap = devm_regmap_init_spmi_ext(sdev, &spmi_regmap_config);Hi Ivan, I have a general question about this driver/layer. Since the driver is using regmap, why does it need to be qcom-*spmi*-pmic ? could we drop the spmi part? regmap's point is abstraction of the bus technology, and indeed some PMICs use i2c.
This is driver for SPMI device, so no. The child device/drivers are different question, but I don't want to start that discussion again. Regards, Ivan