On Tue, Nov 4, 2014 at 11:33 AM, Ivan T. Ivanov [off-list ref] wrote:

+       ret = regmap_read(map, PMIC_SUBTYPE, &subtype);
+       if (ret < 0)
+               return ret;
+
+       rev2 = regmap_read(map, PMIC_REV2, &rev2);
+       if (ret < 0)
+               return ret;

I think you meant:
ret = regmap_read(map, PMIC_REV2, &rev2);

+
+       rev3 = regmap_read(map, PMIC_REV3, &rev3);

Likewise.

+       if (ret < 0)
+               return ret;
+
+       rev4 = regmap_read(map, PMIC_REV4, &rev4);

Likewise.

+       if (ret < 0)
+               return ret;