Re: [PATCH] mfd: qcom-spmi-pmic: Add support for more chips versions
From: Bjorn Andersson <hidden>
Date: 2014-11-05 18:11:54
Also in:
linux-arm-msm, lkml
On Tue, Nov 4, 2014 at 5:33 AM, Ivan T. Ivanov [off-list ref] wrote: [..]
quoted hunk ↗ jump to hunk
@@ -28,11 +144,27 @@ static int pmic_spmi_probe(struct spmi_device *sdev) { struct device_node *root = sdev->dev.of_node; struct regmap *regmap; + struct property *prop; + int major, minor, ret; + char *name, compatible[32]; regmap = devm_regmap_init_spmi_ext(sdev, &spmi_regmap_config); if (IS_ERR(regmap)) return PTR_ERR(regmap); + ret = pmic_spmi_read_revid(regmap, &name, &major, &minor); + if (!ret) { + snprintf(compatible, ARRAY_SIZE(compatible), "qcom,%s-v%d.%d", + name, major, minor); + prop = kzalloc(sizeof(*prop), GFP_KERNEL); + if (prop) { + prop->name = kstrdup("compatible", GFP_KERNEL); + prop->value = kstrdup(compatible, GFP_KERNEL); + prop->length = strlen(prop->value); + of_update_property(root, prop); + } + } +
Why would you do this? What benefit does it give to patch the of_node to have a more specific compatible? It is no longer matching any compatible defined in the kernel and is anyone actually looking at this? Reading out the revid information and providing that in some way to the children could be beneficial, except for qpnp already giving you this version information per block. [..]
quoted hunk ↗ jump to hunk
@@ -45,7 +177,17 @@ static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,spmi-pmic" }, { .compatible = "qcom,pm8941" }, { .compatible = "qcom,pm8841" }, + { .compatible = "qcom,pm8019" }, + { .compatible = "qcom,pm8226" }, + { .compatible = "qcom,pm8110" }, { .compatible = "qcom,pma8084" }, + { .compatible = "qcom,pmi8962" }, + { .compatible = "qcom,pmd9635" }, + { .compatible = "qcom,pm8994" }, + { .compatible = "qcom,pmi8994" }, + { .compatible = "qcom,pm8916" }, + { .compatible = "qcom,pm8004" }, + { .compatible = "qcom,pm8909" }, { }
This part is good, please send this out on it's own. Regards, Bjorn