Re: [PATCH] mfd: qcom-spmi-pmic: Add support for more chips versions
From: Ivan T. Ivanov <hidden>
Date: 2014-11-05 13:50:15
Also in:
linux-arm-msm, lkml
On Wed, 2014-11-05 at 13:49 +0100, Andreas Färber wrote:
Hi, Am 04.11.2014 um 14:33 schrieb Ivan T. Ivanov:quoted
Update compatible string with runtime detected chip revision information, for example qcom,pm8941 will become qcom,pm8941-v1.0.That's not what the patch does though?
Patch add support for more chips and make compatible property more specific. Will correct description.
quoted
Signed-off-by: Ivan T. Ivanov <redacted> --- .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 18 ++- drivers/mfd/qcom-spmi-pmic.c | 142 +++++++++++++++++++++ 2 files changed, 156 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txtb/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt index 7182b88..bbe7db8 100644--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt@@ -15,10 +15,20 @@ each. A function can consume one or more of these fixed-size registerregions. Required properties: - compatible: Should contain one of: - "qcom,pm8941" - "qcom,pm8841" - "qcom,pma8084" - or generalized "qcom,spmi-pmic". + qcom,pm8941, + qcom,pm8841, + qcom,pm8019, + qcom,pm8226, + qcom,pm8110, + qcom,pma8084, + qcom,pmi8962, + qcom,pmd9635, + qcom,pm8994, + qcom,pmi8994, + qcom,pm8916, + qcom,pm8004, + qcom,pm8909,Please either keep the strings consistently quoted, or drop the trailing comma to avoid any confusion of where it terminates.
Sure, will fix it. Thank you, Ivan