Thread (26 messages) 26 messages, 3 authors, 2012-08-21

Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

From: Mark Brown <hidden>
Date: 2012-08-21 14:20:14
Also in: linux-arm-kernel, linux-input, linux-omap, lkml

On Tue, Aug 21, 2012 at 05:09:24PM +0300, Felipe Balbi wrote:
You can't possibly understand what that'll print. First of all, VEN_ID_H
and VEN_ID_L should be ORed together. Second, the user will see the same
message four times in a row, with different values, but see that driver
claims that all four values refer to the device id. What this should do,
is at least combine all four messages into a single one of the format:
dev_(dbg|info)(&i2c->dev, "SMSCxxx devid: %02x rev: %02x venid: %02x\n",
	devid, rev, (venid_h << 8) | venid_l);
or something similar.
Yes, I agree that the formatting here should also be improved - as I
said in one of my earlier mails if any of these things are fixed things
that should never change the driver should instead verify the value
rather than log it.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help