Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

From
Mark Brown <hidden>
Date
2012-08-21 13:49:40
Also in
linux-arm-kernel, linux-input, linux-omap, lkml
Reply to
Felipe Balbi, 2012-08-21
On Tue, Aug 21, 2012 at 04:27:44PM +0300, Felipe Balbi wrote:
I still beg to differ. Even if it fails, dmesg will still contain the
message (provided you have it enabled). I really don't think we want
this to print to console on every boot.
Only if it's enabled which is the trick...
If you're still testing your new batch of boards, you're not just a
simple user and you will have debugging enabled anyway. dev_info() will
be visible to anyone who's got a console running. Not sure how useful
that would be to my neighbor.
Also think about hobbyists and so on, and ideally at some point the
people using distros.  We shouldn't be requiring kernel rebuilds for
this sort of diagnostic information.  I guess sysfs is another option
but frankly the overhead on boot just doesn't seem meaningful in the
context of the overall kernel boot style - I'd really expect people who
are bothered by this sort of output would be raising the minimum log
level appearing on the console.

Attachments

Thread (26 messages) 26 messages, 3 authors, last reply 2012-08-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help