Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

On Tue, Aug 21, 2012 at 02:22:22PM +0100, Mark Brown wrote:

On Tue, Aug 21, 2012 at 03:42:45PM +0300, Felipe Balbi wrote:

quoted

On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote:

quoted

quoted

+	regmap_read(smsc->regmap, SMSC_DEV_ID, &ret);
+	dev_dbg(&i2c->dev, "SMSC Device ID: %d\n", ret);

quoted

quoted

I'd make these log messages dev_info() or something.

quoted

dev_info() ? It'lll just make boot noisier for no good reason. Which
user wants to see this during boot up ? That's a debugging feature for
develop IMHO.

Most of the registers appeared to be chip revision information which is
most definitely useful to tell people about, though possibly with neater
formatting ("why is this batch of boards failing...  oh, right").  If
they're fixed device IDs then the driver should instead be verifying
that the registers contain the expected values and bombing out if they
don't.  Either way dev_dbg() isn't too helpful.

I still beg to differ. Even if it fails, dmesg will still contain the
message (provided you have it enabled). I really don't think we want
this to print to console on every boot.

If you're still testing your new batch of boards, you're not just a
simple user and you will have debugging enabled anyway. dev_info() will
be visible to anyone who's got a console running. Not sure how useful
that would be to my neighbor.

-- 
balbi