Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature

Hi,

On Tue, Aug 21, 2012 at 05:17:37PM +0530, Poddar, Sourav wrote:

quoted

quoted

+     if (type & IRQ_TYPE_LEVEL_HIGH)
+             sg->int_lvl[bank] |= bit;
+     else if (type & IRQ_TYPE_LEVEL_LOW)
+             sg->int_lvl[bank] &= ~bit;
+     else
+             return -EINVAL;

this looks wrong. You could have a user who wants to trigger on both
HIGH and LOW levels, no ?

Yes, I think there can be a scenario where gpio_keys are attached
to this driver and signals a "key press" at low and "key release" at
high. ?
 Will figure out a way to add support to check for case where
both High and low levels are used.

could probably be done on a separate patch, maybe... Just now I saw that
HIGH and LOW levels use the same bit.

-- 
balbi