Thread (7 messages) 7 messages, 2 authors, 2012-01-08
STALE5272d REVIEWED: 2 (0M)
Revisions (2)
  1. rfc [diff vs current]
  2. v2 current

[RFC PATCH v2 1/9] arm: avoid using on_each_cpu hard coded ret value

From: Gilad Ben-Yossef <gilad@benyossef.com>
Date: 2012-01-08 13:35:27
Also in: linux-arm-kernel, lkml
Subsystem: arm pmu profiling and debugging, arm port, performance events subsystem, the rest · Maintainers: Will Deacon, Mark Rutland, Russell King, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Linus Torvalds

on_each_cpu always returns a hard coded return code of zero.

Removing all tests based on this return value saves run time
cycles for compares and code bloat for branches.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Acked-by: Peter Zijlstra <redacted>
Reviewed-by: Michal Nazarewicz <redacted>
CC: Will Deacon <redacted>
CC: Peter Zijlstra <redacted>
CC: Paul Mackerras <redacted>
CC: Ingo Molnar <redacted>
CC: Arnaldo Carvalho de Melo <redacted>
CC: Russell King <redacted>
CC: Grant Likely <redacted>
CC: Rob Herring <redacted>
CC: linux-arm-kernel@lists.infradead.org
CC: devicetree-discuss@lists.ozlabs.org
---
 arch/arm/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 5bb91bf..6e9acb7 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c
@@ -616,7 +616,7 @@ static int __init
 cpu_pmu_reset(void)
 {
 	if (cpu_pmu && cpu_pmu->reset)
-		return on_each_cpu(cpu_pmu->reset, NULL, 1);
+		on_each_cpu(cpu_pmu->reset, NULL, 1);
 	return 0;
 }
 arch_initcall(cpu_pmu_reset);
-- 
1.7.0.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help