Thread (7 messages) 7 messages, 2 authors, 2012-01-08

Re: [RFC PATCH v2 8/9] smp: refactor on_each_cpu to void returning func

From: Russell King - ARM Linux <hidden>
Date: 2012-01-08 16:14:21
Also in: dri-devel, linux-alpha, linux-arm-kernel, linuxppc-dev, lkml

On Sun, Jan 08, 2012 at 03:32:28PM +0200, Gilad Ben-Yossef wrote:
on_each_cpu returns the retunr value of smp_call_function
which is hard coded to 0.

Refactor on_each_cpu to a void function and the few callers
that check the return value to save compares and branches.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Acked-by: Peter Zijlstra <redacted>
Reviewed-by: Michal Nazarewicz <redacted>
CC: David Airlie <redacted>
CC: dri-devel@lists.freedesktop.org
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <redacted>
CC: Grant Likely <redacted>
CC: Rob Herring <redacted>
CC: linuxppc-dev@lists.ozlabs.org
CC: devicetree-discuss@lists.ozlabs.org
CC: Richard Henderson <redacted>
CC: Ivan Kokshaysky <redacted>
CC: Matt Turner <mattst88@gmail.com>
CC: linux-alpha@vger.kernel.org
CC: Thomas Gleixner <redacted>
CC: Ingo Molnar <mingo@redhat.com>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org
CC: Tony Luck <tony.luck@intel.com>
CC: Fenghua Yu <redacted>
CC: linux-ia64@vger.kernel.org
CC: Will Deacon <redacted>
CC: Peter Zijlstra <redacted>
CC: Arnaldo Carvalho de Melo <redacted>
CC: Russell King <redacted>
As there's only one place in the ARM code where we look at the return
value, and you've patched that away in patch 1, this looks fine.  I've
not checked for users outside of arch/arm, so:

Acked-by: Russell King <redacted>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help