Re: [RFC PATCH v2 1/9] arm: avoid using on_each_cpu hard coded ret value
From: Gilad Ben-Yossef <gilad@benyossef.com>
Date: 2012-01-08 16:25:27
Also in:
linux-arm-kernel, lkml
On Sun, Jan 8, 2012 at 6:12 PM, Russell King - ARM Linux [off-list ref] wrote: <SNIP>
quoted
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c index 5bb91bf..6e9acb7 100644 --- a/arch/arm/kernel/perf_event.c +++ b/arch/arm/kernel/perf_event.c@@ -616,7 +616,7 @@ static int __initcpu_pmu_reset(void) { if (cpu_pmu && cpu_pmu->reset) - return on_each_cpu(cpu_pmu->reset, NULL, 1); + on_each_cpu(cpu_pmu->reset, NULL, 1);There's not much to review here...
Oh, I've introduced fatal bugs with less... :-) Thanks for the review. Gilad -- Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "Unfortunately, cache misses are an equal opportunity pain provider." -- Mike Galbraith, LKML