[RFC PATCH 1/9] arm: avoid using on_each_cpu hard coded ret value
From: gilad@benyossef.com (Gilad Ben-Yossef)
Date: 2012-01-03 14:20:19
Also in:
linux-devicetree, lkml
Subsystem:
arm pmu profiling and debugging, arm port, performance events subsystem, the rest · Maintainers:
Will Deacon, Mark Rutland, Russell King, Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo, Namhyung Kim, Linus Torvalds
on_each_cpu always returns a hard coded return code of zero. Removing all tests based on this return value saves run time cycles for compares and code bloat for branches. Cc: Michal Nazarewicz <redacted> CC: Will Deacon <redacted> CC: Peter Zijlstra <redacted> CC: Paul Mackerras <redacted> CC: Ingo Molnar <redacted> CC: Arnaldo Carvalho de Melo <redacted> CC: Russell King <redacted> CC: Grant Likely <redacted> CC: Rob Herring <redacted> CC: linux-arm-kernel at lists.infradead.org CC: devicetree-discuss at lists.ozlabs.org --- arch/arm/kernel/perf_event.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
index 88b0941..bfd58d8 100644
--- a/arch/arm/kernel/perf_event.c
+++ b/arch/arm/kernel/perf_event.c@@ -617,7 +617,7 @@ static int __init cpu_pmu_reset(void) { if (cpu_pmu && cpu_pmu->reset) - return on_each_cpu(cpu_pmu->reset, NULL, 1); + on_each_cpu(cpu_pmu->reset, NULL, 1); return 0; } arch_initcall(cpu_pmu_reset);
--
1.7.0.4