Re: [PATCH 2/2] fs: direct-io: use DIV_ROUND_UP helper macro for calculations
From: Christophe Leroy <hidden>
Date: 2021-05-25 08:34:14
Also in:
linux-fsdevel, lkml
Wu Bo [off-list ref] a écrit :
quoted hunk ↗ jump to hunk
From: Wu Bo <redacted> Replace open coded divisor calculations with the DIV_ROUND_UP kernel macro for better readability. Signed-off-by: Wu Bo <redacted> --- fs/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/direct-io.c b/fs/direct-io.c index b2e86e7..6e7d402 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c@@ -195,7 +195,7 @@ static inline int dio_refill_pages(struct dio*dio, struct dio_submit *sdio) iov_iter_advance(sdio->iter, ret); ret += sdio->from; sdio->head = 0; - sdio->tail = (ret + PAGE_SIZE - 1) / PAGE_SIZE; + sdio->tail = DIV_ROUND_UP(ret, PAGE_SIZE);
Use PFN_UP() instead.
sdio->to = ((ret - 1) & (PAGE_SIZE - 1)) + 1; return 0; } -- 1.8.3.1