Hi Oliver,

On Tue, Sep 11, 2012 at 07:42:19AM +0200, Oliver Hartkopp wrote:

On 10.09.2012 22:08, Kurt Van Dijck wrote:

quoted

But the initial name must have been set properly already in that case...

Yes it is.

See register_netdevice()

http://lxr.linux.no/#linux+v3.5.3/net/core/dev.c#L5453


at the end NETDEV_REGISTER is notified:

http://lxr.linux.no/#linux+v3.5.3/net/core/dev.c#L5552

So it would be pretty elegant to create the LED trigger name in the notifier.
This would allow to remove that code at the current init function too.

That would indeed be elegant, but in the current implementation
triggers only works for supported drivers, while putting registration in
the notifier would imply to use it also in unsupported ones, where you
would get a trigger which never triggers.

Is that what you had in mind?

Of course that would simplify another bit trigger integration to the
driver... if the target is to have support for all drivers that's a good
thing, through I think that triggers are mostly useful on embedded drivers.

Cheers,
Fabio

-- 
Fabio Baltieri