Re: [PATCH can-next v6] can: add tx/rx LED trigger support
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2012-08-01 21:05:34
Also in:
lkml
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2012-08-01 21:05:34
Also in:
lkml
Fabio Baltieri [off-list ref] hat am 1. August 2012 um 20:21 geschrieben:
so, v6, change trigger names for fixed size allocation capped to (IFNAMSIZ + 4) and removed kasprintf as suggested by Oliver (thanks!). This also has the side effect of reducing the error path to just one check to devres_alloc return value... nice! I've put CAN_LED_NAME_SZ definition with the active function declaration, but used sizeof(priv->tx_led_trig_name) as snprintf length argument in the code, as it looks cleaner to me.
Yes. Nice improvement. Thanks Fabio! Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>