On Tue, Jul 31, 2012 at 10:46:57AM +0200, Wolfgang Grandegger wrote:

Hi Fabio,

On 07/30/2012 09:20 PM, Fabio Baltieri wrote:

quoted

This patch implements the functions to add two LED triggers, named
<ifname>-tx and <ifname>-rx, to a canbus device driver.

Triggers are called from specific handlers by each CAN device driver and
can be disabled altogether with a Kconfig option.

The implementation keeps the LED on when the interface is UP and blinks
the LED on network activity at a configurable rate.

This only supports can-dev based drivers, as it uses some support field
in the can_priv structure.

Supported drivers should call can_led_init(), can_led_exit() and
can_led_event() as needed.

Supported events are:
- CAN_LED_EVENT_OPEN: turn on tx/rx LEDs
- CAN_LED_EVENT_STOP: turn off tx/rx LEDs
- CAN_LED_EVENT_TX: trigger tx LED blink
- CAN_LED_EVENT_RX: trigger tx LED blink

Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Wolfgang Grandegger <redacted>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Fabio Baltieri <redacted>
---

Hi all!

This is the v3 of my CAN LED trigger patch.  It's a major refactoring of the v2
that was discussed about three months ago concluding with the idea that
implementing the oneshot triggering code in the LED framework would be a better
solution.

This is the old thread for reference:
http://marc.info/?l=linux-can&m=133521499002898&w=2

So, generic oneshot trigger code is now merged in mainline (see 5bb629c), and
these are the changes in the v3:

Nice, thanks for your patience (and not giving up).

Thanks to you for the review... no intention of giving up, I'm learning
a lot from this! ;-)

Fabio