On Mon, Sep 10, 2012 at 09:01:21PM +0200, Oliver Hartkopp wrote:

On 10.09.2012 20:40, Fabio Baltieri wrote:

quoted

On Mon, Sep 10, 2012 at 08:25:50PM +0200, Oliver Hartkopp wrote:

quoted

On 10.09.2012 16:28, Kurt Van Dijck wrote:

quoted

Fabio,

I followed all your contribution to this patch.

Thanks!

quoted

You created that nice function but you are accessing priv->tx_led_trig below
without checking the output of save_candev_priv() ...

Also, I noticed you removed the namespace check... wasn't it needed?
(just asking, I have no idea).

I don't actually know.
Anyone?

quoted

quoted

quoted

+	if (msg == NETDEV_CHANGENAME) {

I do have a second remark.

What about always using the notifiers to name the LED triggers?

Looking into

http://lxr.linux.no/#linux+v3.5.3/include/linux/netdevice.h#L1526

we have NETDEV_CHANGENAME but what about

	NETDEV_REGISTER

???

When changing and updating the LED trigger name always inside the notifier, we
should never run into any locking or race conditions ...

What do you think about this idea?

But the initial name must have been set properly already in that case...

Kurt