Thread (15 messages) read the whole thread 15 messages, 5 authors, 2013-09-27

Re: [PATCH 1/2] android: Add skeleton of BlueZ Android daemon

From: Lukasz Rymanowski <hidden>
Date: 2013-09-23 19:28:44

Hi Marcel,

On Mon, Sep 23, 2013 at 11:51 AM, Frederic Danis
[off-list ref] wrote:
Hello Marcel,

On 21/09/2013 19:14, Marcel Holtmann wrote:
quoted
Hi Fred,
quoted
Define local mapping to glib path, otherwise this has to be inside
central
place in the build repository.

Retrieve Bluetooth version from configure.ac.
---
.gitignore         |    2 +
Android.mk         |    9 ++++
Makefile.am        |    1 +
Makefile.android   |    7 ++++
android/Android.mk |   24 +++++++++++
android/main.c     |  119
++++++++++++++++++++++++++++++++++++++++++++++++++++
configure.ac       |    5 +++
7 files changed, 167 insertions(+)
create mode 100644 Android.mk
create mode 100644 Makefile.android
create mode 100644 android/Android.mk
create mode 100644 android/main.c

lets split this out a little bit. Code additions should not be intermixed
with additions to the build system and especially configure options.

I rather not have a top-level Android.mk. It should be enough to provide
an android/Android.mk.
 BTW, do you expect to have only one Android.mk for the whole project or
this is OK for you to have smaller Android.mk in different subfolders like
/src/shared etc. Both ways are valid.

Br
Lukasz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help