Thread (15 messages) 15 messages, 5 authors, 2013-09-27

Re: [PATCH 2/2] android: Android version of log.c

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2013-09-27 01:58:11

Hi Fred,
<snip>
quoted
quoted
@@ -110,10 +137,22 @@ int main(int argc, char *argv[])
	sa.sa_handler = signal_handler;
	sigaction(SIGINT, &sa, NULL);
	sigaction(SIGTERM, &sa, NULL);
+	sigaction(SIGUSR2, &sa, NULL);
+
+	__btd_log_init(option_debug, option_detach);
+
+	/* no need to keep parsed option in memory */
+	free_options();
+
+	DBG("Entering main loop");
Don't do this debug. It is not helpful. The main() is so short, no point in logging that.
I need at least one DBG call to be able to build, otherwise I got "undefined reference to `__start___debug'" error messages.
So, this one seems ok to me.
fair enough for the beginning. Just remove it once you have more than one DBG in the source code and this is no longer needed.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help