Re: [PATCH 1/2] android: Add skeleton of BlueZ Android daemon

Hi Marcel,

On Fri, Sep 27, 2013 at 03:56:14AM +0200, Marcel Holtmann wrote:

Hi Andrei,

quoted

quoted

quoted

quoted

quoted

Define local mapping to glib path, otherwise this has to be inside
central
place in the build repository.

Retrieve Bluetooth version from configure.ac.
---
.gitignore         |    2 +
Android.mk         |    9 ++++
Makefile.am        |    1 +
Makefile.android   |    7 ++++
android/Android.mk |   24 +++++++++++
android/main.c     |  119
++++++++++++++++++++++++++++++++++++++++++++++++++++
configure.ac       |    5 +++
7 files changed, 167 insertions(+)
create mode 100644 Android.mk
create mode 100644 Makefile.android
create mode 100644 android/Android.mk
create mode 100644 android/main.c

lets split this out a little bit. Code additions should not be intermixed
with additions to the build system and especially configure options.

I rather not have a top-level Android.mk. It should be enough to provide
an android/Android.mk.

BTW, do you expect to have only one Android.mk for the whole project or
this is OK for you to have smaller Android.mk in different subfolders like
/src/shared etc. Both ways are valid.

While having a single huge Android makefile is somehow make sense it would have
several disadvantages:
- we cannot use local build with "mm" for building for example only tools
 or libs
- Android.mk will become very large and difficult to read

I have no idea what this means. Lets start with a single
android/Android.mk and then go from there. I am strictly against
cluttering the whole project with Android specific make files.

OK, we will use the single Android makefile, it is actually not that big.

Best regards 
Andrei Emeltchenko