Re: [RFCv1 00/11] Handling physical and logical link

Hi Marcel and Andrei -

On Thu, 25 Oct 2012, Andrei Emeltchenko wrote:

Hi Marcel,

On Thu, Oct 25, 2012 at 06:11:08AM -0700, Marcel Holtmann wrote:

quoted

Hi Andrei,

quoted

Set of patches adding handling for physical and logical link
complete events.

Changes:
	* rfcv1: Rebased on top of Mat's patches, preserve Marcel's ack for
	not-changed-much patches only.
	* rfcv0: original

all in all, this looks pretty good to me.

Mat, can you take an extra look at it as well.

What is actually missing after this set of patches?

Still a lot. First it is finishing physical link establishment and then
channel move.

I looked things over and don't have any major comments or issues.

The main AMP/A2MP/L2CAP task right now is to get the right information 
propagated to L2CAP using l2cap_physical_cfm() and 
l2cap_logical_cfm().  After that, there are the various "Placeholder" 
comments in l2cap_core.c

There is another piece of work involving L2CAP ERTM resegmentation 
that depends on MSG_MORE support:

http://www.spinics.net/lists/linux-bluetooth/msg25615.html


--
Mat Martineau

Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation