Thread (85 messages) 85 messages, 4 authors, 2012-11-14

Re: [RFCv1 05/11] Bluetooth: AMP: Add Logical Link Create function

From: Andrei Emeltchenko <hidden>
Date: 2012-10-29 09:24:57

Hi Mat,

On Fri, Oct 26, 2012 at 10:01:01AM -0700, Mat Martineau wrote:

...
quoted
@@ -3948,13 +3955,15 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn,
			goto done;
		}

-			/* check compatibility */
-
		if (!chan->ctrl_id)
			l2cap_send_efs_conf_rsp(chan, buf, cmd->ident,
						0);
-			else
-				chan->ident = cmd->ident;
+			else {
+				if (l2cap_check_efs(chan)) {
+					amp_create_logical_link(chan);
+					chan->ident = cmd->ident;
+				}
+			}
Minor style issue - if one block of an if/else needs braces, then
they all get braces.
Sure. Will fix this.

Best regards 
Andrei Emeltchenko 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help