Re: [PATCHv4 07/17] Bluetooth: AMP: Remote AMP ctrl definitions

Hi Mat,

On Thu, Sep 13, 2012 at 08:50:24AM -0700, Mat Martineau wrote:

...

quoted

+struct amp_ctrl {
+	struct list_head	list;
+	struct kref		kref;
+	__u8			id;
+	__u16			assoc_len_so_far;
+	__u16			assoc_rem_len;
+	__u16			assoc_len;
+	__u8			*assoc;
+};

I think you have the necessary information here.  There should be no
need to also track the remote device in the amp_ctrl struct because
the amp_mgr that owns the list of controllers is only referring to
one remote device, right?

amp_mgr tracks the list of remote AMP controllers found in the A2MP
Discover Response. It is not limited to one remote controller.

Though it is usually only one AMP controller but Spec says that:

<------8<-------------------------------------------------------------------------
|  Controller List (3 or more octets)
|  Controller List is variable in length. It consists of 1 or more entry.
|  Each entry is comprised of a Controller ID, a Controller Type and a Controller
|  status.
<------8<-------------------------------------------------------------------------

Then for each controller we send A2MP Getinfo Request.

Best regards 
Andrei Emeltchenko