Thread (267 messages) flat view 267 messages, 5 authors, 2012-09-27

Re: [RFCv2 08/20] Bluetooth: AMP: Remote AMP ctrl definitions

From: Andrei Emeltchenko <hidden>
Date: 2012-07-25 11:26:18

Hi Gustavo,

On Tue, Jul 24, 2012 at 06:13:42PM -0300, Gustavo Padovan wrote:
quoted
diff --git a/include/net/bluetooth/a2mp.h b/include/net/bluetooth/a2mp.h
index 012f573..8ba236c 100644
--- a/include/net/bluetooth/a2mp.h
+++ b/include/net/bluetooth/a2mp.h
@@ -29,6 +29,9 @@ struct amp_mgr {
 
 	struct list_head	phy_links;
 	struct mutex		phy_links_lock;
+
+	struct list_head	amp_ctrls;
+	struct mutex		amp_ctrls_lock;
Have you checked for RCU here, are they worthwhile? and why is it better than
spinlocks?  This is for both locks above.
I want to be able to sleep inside critical section and using RCU is
overkill here.

Best regards 
Andrei Emeltchenko 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help